refactor: convert installedapps:delete command to yargs #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
julieganzer
reviewed
Feb 25, 2025
| const command = 'installedapps:delete [id]' | ||
|
|
||
| // TODO: should this be worded "uninstall an app"? | ||
| const describe = 'delete an installed app' |
There was a problem hiding this comment.
TODO? either change the describe, or remove the todo?
julieganzer
reviewed
Feb 25, 2025
src/commands/installedapps/delete.ts
Outdated
| apiCommandBuilder(yargs) | ||
| .option('location', { | ||
| alias: 'l', | ||
| describe: 'if prompting for an installed apps, include only installed apps in the specified location(s)', |
There was a problem hiding this comment.
nit.. grammar?
'an installed apps'
There was a problem hiding this comment.
Oops, also fixed. Thanks for the notes!
f3de4e9 to
676c8cd
Compare
676c8cd to
2f8e617
Compare
julieganzer
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installedapps:deletecommand to yargschoosefunctions to support a custom prompt message (changes toutil-util.ts)