Expedites #1934 and #1979 to Prod #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constant should be 100, but I resolved a conflict during a rebase incorrectly when prepping the original PR and it got set to 11 instead of 100.
If the bulb's color temperature changes because of an ST-initiated user requested setpoint, we emit that directly instead of clamping to the step size. This is to remain consistent with the way things are done on the rest of the platform with other integrations.
The existing logic utilized the device persistent fields to determine if a range update was needed, as to avoid un-necessary attribute emits. This would lead to existing devices not ever emitting the min/max color temp range values if the saved min/max matched what was reported by the API. This is adjusted to use the cached latest state for the device instead, so that we can detect the `nil` if the device has never emitted a value for its range.
There was a slight bug with the previous port of the rounding logic from Matter/Zigbee over to Hue because I was reading two different places in the code and getting them confused in my head. This change does the following: 1. Only use the 100 step size constraint when computing the min/max values instead of everywhere. This is in line with how this is handled elsewhere on the platform. 2. Use normal rounding everywhere else.
|
Channel deleted. |
lelandblue
approved these changes
Mar 6, 2025
Test Results 64 files 410 suites 0s ⏱️ Results for commit f4677b0. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against f4677b0 |
varzac
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expedites #1934 and #1979 to Production