-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core)!: make getActionablePendingAction a view function #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coverage These tests take too long with the local profile, and it would be good practice to have unit tests covering all branches anyway.
Added tests for the external function, and added an internal function that mutates the queue.
LCOV of commit
|
samooyo
requested changes
Jan 30, 2024
samooyo
previously approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ALL GOOD
Paulalex85
reviewed
Jan 30, 2024
fireboss777
reviewed
Jan 31, 2024
fireboss777
approved these changes
Jan 31, 2024
Paulalex85
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The front-end cannot make calls to functions that are not view (they could do a
simulate
but it's unergonomic).Thus, the
getActionablePendingAction
has been madeview
and a new_getActionablePendingAction
internal function has been added, for removing the empty items at the front of the queue.NOTE: the coverage commands have been updated to ignore fuzzing and invariant tests, since they take too long with the local profile. Also, it would be good practice to have full coverage with only unit tests (without taking fuzzing into account).