Text Fallback for unavailable glyphs #5
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1
If one of the two characters can't be found inside our font, we simply return a
<text>
element instead of a<path>
. This is not an optimal solution, since we don't have control over how the resulting svg will look, but for now the simplest solution. Also the png version might not work when deployed, since it will rely on system fonts on the server.In the future we could look at Noto, but unfortunately that's also not available as a single font file. That means we'd have to iterate through several files and even merge two paths if we can't find both characters in a single font file.