Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: little fixing in code engine #126

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

Sma1lboy
Copy link
Owner

@Sma1lboy Sma1lboy commented Feb 19, 2025

Summary by CodeRabbit

  • New Features

    • Introduced a dedicated configuration for Docker services in the development environment.
    • Updated the web preview with new navigation controls for a streamlined browsing experience.
    • Enabled conditional display of the code editor panel based on context.
    • Improved modal layering for enhanced visibility.
  • Refactor

    • Enhanced asynchronous handling for project and chat data to provide smoother updates.
    • Optimized build processes to prevent duplicate operations during container runs.

Copy link

coderabbitai bot commented Feb 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several asynchronous and UI improvements across both backend and frontend modules. Notably, a new Docker window configuration is added to the tmux config, and the project model now treats chats as an asynchronous resource. Resolver and service methods have been updated to await chat data. In the frontend, conditional rendering is applied to the CodeEngine panel, and enhanced navigation and state management features have been added to the web preview and CodeEngine components. Additionally, the run project API now includes a check for existing Docker containers and throttles parallel build requests.

Changes

File(s) Change Summary
.tmuxinator/dev.yml Added a new window labeled docker under the windows section with root <%= ENV["PWD"] %> and a pane that displays a focus message and starts Docker services using docker compose up.
backend/.../project.model.ts
backend/.../project.resolver.ts
backend/.../project.service.ts
Updated the asynchronous handling of project chats:
• Changed chats type in Project from Chat[] to Promise<Chat[]>.
• Modified the getChats resolver to await the chat promise.
• Revised service methods (getProjectsByUser, getProjectById, and bindProjectAndChat) to use Promise.all and await chat filtering and binding operations.
frontend/(main)/Home.tsx Adjusted UI rendering logic by conditionally displaying the ResizablePanel containing the CodeEngine component only when chatId is truthy, and added a padded div wrapper for the CodeEngine.
frontend/.../runProject/route.ts Introduced a new asynchronous function checkExistingContainer to detect existing Docker containers.
Implemented a processingRequests set to prevent duplicate builds, enhanced error handling to check for container conflicts, and updated the build logic accordingly.
frontend/.../code-engine/code-engine.tsx
frontend/.../code-engine/project-context.tsx
frontend/.../code-engine/web-view.tsx
Updated state management and effects in multiple CodeEngine-related components:
• Added debugging logs and updated dependency arrays.
• Modified ResponsiveToolbar to accept an isLoading prop.
• In project-context.tsx, replaced state variable with a ref for caching and added side-effect hooks for local storage management.
• Enhanced navigation functions and URL handling in web-view.tsx.
frontend/.../project-modal.tsx Adjusted the modal’s outer <div> by adding a z-50 class to modify its z-index to ensure proper overlay over other elements.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant RC as RunProject API (route.ts)
    participant DC as Docker Command
    U->>RC: Initiate build and run request
    RC->>RC: Check processingRequests for projectPath
    alt Build not in progress
        RC->>DC: Call checkExistingContainer(projectPath)
        DC-->>RC: Return container ID (or null)
        RC->>DC: Execute 'docker compose up'
        DC-->>RC: Return container details
        RC->>U: Return container information
    else Build in progress
        RC->>U: Return pending build response
    end
Loading

Suggested reviewers

  • ZHallen122

Poem

I'm a bunny coding through the night,
With async hops and panels so bright.
Docker whispers in my ear,
“Run your code without fear!”
In fields of code I leapt with glee,
Celebrating changes, wild and free.
🐇💻

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

frontend/src/app/(main)/Home.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/frontend/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

frontend/src/components/code-engine/code-engine.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/frontend/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

frontend/src/components/code-engine/project-context.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/frontend/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

  • 6 others

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a65a54 and 07f5313.

⛔ Files ignored due to path filters (1)
  • backend/database.db is excluded by !**/*.db
📒 Files selected for processing (10)
  • .tmuxinator/dev.yml (1 hunks)
  • backend/src/project/project.model.ts (1 hunks)
  • backend/src/project/project.resolver.ts (1 hunks)
  • backend/src/project/project.service.ts (3 hunks)
  • frontend/src/app/(main)/Home.tsx (1 hunks)
  • frontend/src/app/api/runProject/route.ts (5 hunks)
  • frontend/src/components/code-engine/code-engine.tsx (10 hunks)
  • frontend/src/components/code-engine/project-context.tsx (5 hunks)
  • frontend/src/components/code-engine/web-view.tsx (3 hunks)
  • frontend/src/components/project-modal.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Sma1lboy Sma1lboy merged commit f529ac9 into main Feb 19, 2025
1 of 3 checks passed
ZHallen122 pushed a commit that referenced this pull request Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant