Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[choreolib] Fix compilation error in Trajectory::GetTotalTime() #1149

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[choreolib] Fix compilation error in Trajectory::GetTotalTime() #1149

merged 1 commit into from
Jan 17, 2025

Conversation

calcmogul
Copy link
Member

Fixes #1147.

@calcmogul calcmogul merged commit 8d6dbfd into SleipnirGroup:main Jan 17, 2025
33 checks passed
@calcmogul calcmogul deleted the choreolib-fix-compilation-error-in-trajectory-get-total-time branch January 17, 2025 06:04
@onthegrid007
Copy link

I just tried pulling the repo in vscode as a online vendor, how long untill these breaking changes get pushed downstream?
I also have an error for not Explicitly providing the Year parameter when calling Flipped(), I am not sure if i can manually fix these but if the changes were pushed i could just update the repo...

@calcmogul calcmogul mentioned this pull request Jan 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[choreolib] [cpp] Trajectory::GetTotalTime() doesn't unwrap optional, renders class virtually unusable
2 participants
@calcmogul @onthegrid007