Tests for config.js #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sleavely
commented
May 13, 2020
Comment on lines
+10
to
+25
| // Reset the config/context/state singletons with jest.resetModules(). | ||
| // Unfortunately this seems to destroy mocks from the main scope | ||
| // so we have to redefine them for each test; I tried using | ||
| // `delete require.cache[require.resolve('./config')]` | ||
| // but Jest overrides the NodeJS require-mechanism and | ||
| // refuses to let you clear individual entries from the cache. | ||
| jest.resetModules() | ||
| jest.doMock('./utils/fs') | ||
| fs = require('./utils/fs') | ||
|
|
||
| // Emulate a config file | ||
| const configPath = './config.virtual' | ||
| fs.findUpwardsFile.mockResolvedValue(configPath) | ||
| jest.doMock(configPath, virtualConfig, { virtual: true }) | ||
|
|
||
| config = jest.requireActual('./config') |
There was a problem hiding this comment.
This part could probably be done more efficiently if we move the require-ing of the dynamic config file path to a separate function from the parser, but a lot of frustration went into this solution and I'm still a bit angry with Jest about it so it'll stay for now.
amoj
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.