Skip to content

Commit

Permalink
formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
robby-rob-slalom committed Oct 19, 2023
1 parent 2b0398b commit b4448f0
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
7 changes: 4 additions & 3 deletions tap_lucid_scim/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
from __future__ import annotations

from typing import Any, Callable
from memoization import cached
from urllib.parse import parse_qsl

import requests
from memoization import cached
from singer_sdk.authenticators import BearerTokenAuthenticator
from singer_sdk.streams import RESTStream
from urllib.parse import parse_qsl

from tap_lucid_scim.pagination import LucidScimPaginator

Expand Down Expand Up @@ -66,7 +67,7 @@ def get_new_paginator(self) -> LucidScimPaginator:
"""
return LucidScimPaginator(start_value=1, page_size=0)

#TODO: add backoff
# TODO: add backoff
# https://lucidchart.zendesk.com/hc/en-us/community/posts/8678361152020-Rate-Limit-for-Lucid-chart-SCIM-API-s
# 100 request/minute limit with 429 code

Expand Down
7 changes: 3 additions & 4 deletions tap_lucid_scim/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import typing as t
from pathlib import Path


from tap_lucid_scim.client import LucidScimStream

SCHEMAS_DIR = Path(__file__).parent / Path("./schemas")
Expand All @@ -21,7 +20,7 @@ class UsersStream(LucidScimStream):
schema_filepath = SCHEMAS_DIR / "users.json" # noqa: ERA001


#class GroupsStream(LucidScimStream):
# class GroupsStream(LucidScimStream):
# """Define custom stream."""
#
# name = "groups"
Expand All @@ -30,11 +29,11 @@ class UsersStream(LucidScimStream):
# replication_key = None
# schema_filepath = SCHEMAS_DIR / "groups.json" # noqa: ERA001

#class GroupsStream(LucidScimSchemas):
# class GroupsStream(LucidScimSchemas):
# """Define custom stream."""
#
# name = "schemas"
# path = "/Schemas"
# primary_keys: t.ClassVar[list[str]] = ["id"]
# replication_key = None
# schema_filepath = SCHEMAS_DIR / "groups.json" # noqa: ERA001
# schema_filepath = SCHEMAS_DIR / "groups.json" # noqa: ERA001
6 changes: 3 additions & 3 deletions tap_lucid_scim/tap.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ class TapLucidScim(Tap):
description="Custom configuration for streams.",
),
th.Property(
'page_size',
"page_size",
th.IntegerType,
default=None,
description='Result limit for paginated streams'
description="Result limit for paginated streams",
),
th.Property(
"api_url",
Expand All @@ -56,7 +56,7 @@ def discover_streams(self) -> list[streams.LucidScimStream]:
A list of discovered streams.
"""
return [
# streams.GroupsStream(self),
# streams.GroupsStream(self),
streams.UsersStream(self),
]

Expand Down

0 comments on commit b4448f0

Please sign in to comment.