Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status update #96

Merged
merged 13 commits into from
Jun 14, 2021
Merged

Fix status update #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1965fde
Fix status update
nebojsa-prodana Jun 8, 2021
ca87e60
Clean the code a bit
nebojsa-prodana Jun 8, 2021
a0f7606
PR remarks, fix tests
nebojsa-prodana Jun 8, 2021
1659d04
More PR remarks
nebojsa-prodana Jun 8, 2021
ee37d13
Refactor min calculation
maruina Jun 10, 2021
48e7d6e
Replace r.log with just log
maruina Jun 10, 2021
70ebbd9
Remove resetStatus as we don't need it
maruina Jun 10, 2021
c083181
Semplify add/remove finalizer logic by removing the if/else loop
maruina Jun 10, 2021
99e9bf0
Rename submitStatus to updateStatusWithRetry to reflect its behaviour
maruina Jun 10, 2021
63c692d
Replace log.V(1).Info with log.Info
maruina Jun 10, 2021
6760629
Move stage reconciliation under separate method
maruina Jun 10, 2021
9dcee07
Use result.Requeue instead of a separate bool to reduce complexity
maruina Jun 14, 2021
9db2555
Remove unused StagesInitializedReason
maruina Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/v1alpha1/condition_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ const (
// the progressive sync stages have been completed
StagesCompleteReason string = "StagesCompleted"

// StagesProgressingReason represent the fact that some
// of the progressive sync stages are progressing
StagesProgressingReason string = "StagesProgressing"

// StagesFailedReason represent the fact that a
// progressive sync stage has failed
StagesFailedReason string = "StagesFailed"
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/argoproj.skyscanner.net_progressivesyncs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ spec:
type: string
name:
type: string
stage:
phase:
description: StageStatusPhase defines the observed stage phase
enum:
- Progressing
Expand Down
Loading