Reuse context in reconciler

[DiogoMCampos]

Fixes #67.

Two questions:

• I haven't touched requestsForApplicationChange nor requestsForSecretChange as they are called in handler.EnqueueRequestsFromMapFunc(r.requestsForApplicationChange) and handler.EnqueueRequestsFromMapFunc(r.requestsForSecretChange) respectively. Should we?
• I'm reusing the global ctx in tests - is there any better approach?

[sledigabel]

LGTM, but do we know where is the ctx for the Reconcile function coming from and who sets it?
the logic being, it might be a context that has nothing to do with the actual context we want propagated (in anticipation of #63)

[sledigabel]

Fixes #67.

Two questions:

• I haven't touched requestsForApplicationChange nor requestsForSecretChange as they are called in handler.EnqueueRequestsFromMapFunc(r.requestsForApplicationChange) and handler.EnqueueRequestsFromMapFunc(r.requestsForSecretChange) respectively. Should we?
• I'm reusing the global ctx in tests - is there any better approach?

OK So THAT is the answer to my question, the context is initialised there :-)
I think it's ok we can leave that like that for now.

@maruina could prob confirm this.

[maruina]

I think we should change requestsForApplicationChange and requestsForSecretChange as they define they own context (see for example https://github.com/Skyscanner/applicationset-progressive-sync/pull/87/files#diff-a853c97824440aa3801077e1f5661f9087e27091372140f15f89ed5c8d0c5ba6R247)

Regarding the test, I'm not sure about that so I think you can keep the current ctx.

[sledigabel]

I think we should change requestsForApplicationChange and requestsForSecretChange as they define they own context

But if they don't generate the context, what will?
It seems to be that this is the context that gets propagated to the Reconciler?
Presumably the context needs to be instantiated somewhere?

[maruina]

I think we should change requestsForApplicationChange and requestsForSecretChange as they define they own context

But if they don't generate the context, what will?
It seems to be that this is the context that gets propagated to the Reconciler?
Presumably the context needs to be instantiated somewhere?

You are correct. I was already thinking in a kubebuilder 3.0 scenario.

[maruina]

LGTM