Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for 2.0 release #81

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Prepare for 2.0 release #81

merged 1 commit into from
Dec 7, 2016

Conversation

k0nserv
Copy link
Contributor

@k0nserv k0nserv commented Dec 7, 2016 •
edited
Loading

Steps to take from here

  • Merge this PR
  • Make release and tag for v2.0.0
  • Push to CocoaPods

Questions:

  • Deployment target is 8.0, what's the status of this given the Swift 3 support?

cc @bogren, @wolffan

@k0nserv k0nserv mentioned this pull request Dec 7, 2016
Merged
6 tasks
@bogren
Copy link
Contributor

bogren commented Dec 7, 2016

Swift 3 is compatible with iOS 8. With Swift 3 comes the opportunity to also move to iOS 9+ imo.

@k0nserv
Copy link
Contributor Author

k0nserv commented Dec 7, 2016

No reason to increase the minimum deployment target IMO.

@k0nserv k0nserv merged commit e01da78 into master Dec 7, 2016
@k0nserv k0nserv deleted the prepare-for-2.0-release branch December 7, 2016 15:03
@bogren
Copy link
Contributor

bogren commented Dec 7, 2016

CocoaPods 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogren bogren bogren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k0nserv @bogren