Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- example project view controller class simplified #58

Merged
merged 2 commits into from
Apr 6, 2017
Merged

- example project view controller class simplified #58

merged 2 commits into from
Apr 6, 2017

Conversation

slxl
Copy link
Contributor

@slxl slxl commented Jul 18, 2016

No description provided.

@k0nserv
Copy link
Contributor

k0nserv commented Nov 30, 2016

Hey @slxl this looks good. We are merging #67 into master soon so it'll probably have to be updated to Swift 3 after that point

@k0nserv
Copy link
Contributor

k0nserv commented Dec 7, 2016

@slxl #67 is merged now if you wanna rebase this

@k0nserv
Copy link
Contributor

k0nserv commented Apr 5, 2017

@slxl Ping on that rebase :)

k0nserv
k0nserv approved these changes Apr 5, 2017
View reviewed changes
Copy link
Contributor

@k0nserv k0nserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌Thanks for the PR @slxl

@slxl
Copy link
Contributor Author

slxl commented Apr 5, 2017

pardonne moi delay :)

@k0nserv
Copy link
Contributor

k0nserv commented Apr 5, 2017

No problem the same on my part :)

@k0nserv k0nserv merged commit cda67ec into Skyscanner:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0nserv k0nserv k0nserv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slxl @k0nserv