Attributed text support #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using setting the
attributedTextproperty of theUITextField.Setting this value was always possible of course, but the logic of
SkyFloatingLabelTextFieldin reaction to other changes (egisEnabled, active, not active etc) always callsupdateColors()which in turn callsupdateTextColor()which in setting thetextColorvalue of theUITextFieldoverrides any color attributes that have been set in theattributedText, making it basically unusable.With this change, if
attributedTextis set to a non-nil value, any changes totextColorare ignored, and internally the attributed string will remain unchanged whenupdateTextColor()is called, except to set it to the error color in the case of an error.