Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Xcode 10.2 and Swift 5.0 #272

Closed
wants to merge 3 commits into from

Conversation

taher-mosbah
Copy link

Run the migration assistant on framework and test apps, tests are green and 0 warnings.

@taher-mosbah
Copy link
Author

Will update CI script as soon as Xcode 10.2 is available.

@k0nserv
Copy link
Contributor

k0nserv commented Feb 8, 2019

Thanks a bunch @taher-mosbah

@k0nserv
Copy link
Contributor

k0nserv commented Feb 21, 2019

Hey @taher-mosbah CI still seems to have issues here. Do you want to continue looking at it or should I pick it up?

@taher-mosbah
Copy link
Author

Hey @k0nserv I won't have much time coming days, feel free to pick it up, really sorry for that.

@dejanskledar
Copy link

Any updates on this?

@adamszeptycki
Copy link

Any plans to merge it?

@k0nserv
Copy link
Contributor

k0nserv commented May 3, 2019

Hey, I don't have time to work on this, but I am happy to merge it if someone can create a PR that passes CI, specifically that still works for Swift 3.1 which seems broken in this PR

@k0nserv
Copy link
Contributor

k0nserv commented May 6, 2019

I've released version 3.7.0 which specifies the swift_versions attribute in the podspec. This should mean that you can use SkyFloatingLabelTextField in your Swift 5 projects before someone gets the time to look at and finish this PR

@k0nserv
Copy link
Contributor

k0nserv commented Dec 5, 2019

Closed in favour of #290

@k0nserv k0nserv closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants