Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Error Colors for Line, Title, Text #193

Closed
wants to merge 2 commits into from

Conversation

InbarSletean
Copy link
Contributor

This PR adds the customization for the for underline, textfield text and title text colors, when error message is set.

@k0nserv
Copy link
Contributor

k0nserv commented Jan 25, 2018

Hey @InbarSletean this looks pretty good generally. Could you add an entry to CHANGELOG.md under the master section and possibly squash the commits? If you are not comfortable with squashing I can do it instead

@InbarSletean
Copy link
Contributor Author

InbarSletean commented Jan 25, 2018

@k0nserv I've added the changes to the CHANGELOG.md and squashed commits

change podspec

add individual error colors for line, title, text

add unit tests for specific error colors

update log

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@k0nserv
Copy link
Contributor

k0nserv commented May 28, 2018

I've cherry picked the commit and will merge it in #208

@k0nserv k0nserv closed this May 28, 2018
@k0nserv
Copy link
Contributor

k0nserv commented May 28, 2018

Released in 3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants