Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API interface #27

Merged
merged 38 commits into from
Mar 18, 2022
Merged

Remove API interface #27

merged 38 commits into from
Mar 18, 2022

Conversation

peterjan
Copy link

PULL REQUEST

Overview

This PR removes the skyd package with the API interface in favor of using the client.
This makes it so we stop repeating all HTTP request logic everywhere and just make
use of the client as much as possible.

We still keep the API tester because I just think it's useful keep the simple unit tests
for our handlers.

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

Closes #26

Base automatically changed from pj/blocklist-sync to main March 10, 2022 13:33
@peterjan peterjan marked this pull request as draft March 10, 2022 13:38
@peterjan peterjan marked this pull request as ready for review March 11, 2022 15:17
@peterjan peterjan requested a review from ChrisSchinnerl March 16, 2022 12:13
ChrisSchinnerl
ChrisSchinnerl previously approved these changes Mar 16, 2022
ro-tex
ro-tex previously approved these changes Mar 17, 2022
Copy link
Collaborator

@ro-tex ro-tex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. I would fix that name but it can be a F/U.

@peterjan peterjan dismissed stale reviews from ro-tex and ChrisSchinnerl via b403311 March 18, 2022 09:18
@ro-tex ro-tex self-requested a review March 18, 2022 09:38
@ro-tex ro-tex requested a review from ChrisSchinnerl March 18, 2022 09:38
@peterjan peterjan mentioned this pull request Mar 18, 2022
@peterjan peterjan merged commit c0fb8a7 into main Mar 18, 2022
@peterjan peterjan deleted the pj/remove-skyd-api branch March 18, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Client
3 participants