Allow List #11
Merged
Allow List #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
commented
Dec 21, 2021
|
We could F/U with testing although really the only thing we can test here would require setting up a database in testing or mocking the |
ro-tex
approved these changes
Dec 21, 2021
skyd/api.go
Outdated
| // allow list, it returns true if the skylink is present on the allow list | ||
| func (skyd *SkydAPI) IsAllowListed(ctx context.Context, skylink string) bool { | ||
| // build the request to resolve the skylink with skyd | ||
| url := fmt.Sprintf("http://%s:%d/skynet/resolve/%s", skyd.staticSkydHost, skyd.staticSkydPort) |
There was a problem hiding this comment.
F/U: We can check if it's a V2 skylink before making a request.
Also, resolving the skylink can make a nice helper func.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
This PR adds an allow list. It's an initial version but it will give us the option to manually put allow listed (v1) skylinks in the database and have the reported/blocked skylink be verified against that list before proceeding to block it.
Example for Visual Changes
N/A
Checklist
Review and complete the checklist to ensure that the PR is complete before assigned to an approver.
Issues Closed
N/A