Add endpoint to allow for blocking without authentication by using a pow #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5cd2da3 to
3135822
Compare
|
F/U we should probably verify the tags in the endpoint. To prevent people from providing tags which we might have reserved internally. |
peterjan
approved these changes
Dec 21, 2021
| err := api.staticDB.Ping(r.Context()) | ||
|
|
||
| // Apply a timeout. | ||
| ctx, cancel := context.WithTimeout(r.Context(), 5*time.Second) |
|
I didn't thoroughly review the updated structure but it seemed like an improvement for sure. |
|
Merging and deploying this must go together with redeploying the abuse skapp frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
This MR adds a new /block endpoint similar to the existing one. The only difference is, that it requires some proof-of-work as spam protection.
Checklist
Review and complete the checklist to ensure that the PR is complete before assigned to an approver.
Issues Closed