Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
This PR updates the parser regex to catch a skylink that was missed by the parser in an abuse report.
I've updated the regexes and the parser in a way that will detect the missed skylink format (and also other formats that were undetectable up until now), without causing any false positives (which we definitely do not want since we have automated replies now)
The format the skylink was reported at looked like this:
https:// siasky [.]netEABg4mZrsNcedNPazZ4kSFAYBzf7f8ZgHO1Tu1L-NN8Gjg
It's hard to believe the scanner didn't catch this, but it's missing the
/
afternet
.The reason that extracting skylinks from these texts is harder than it seems, is that sometimes the email body contains headers that look like this:
which would label
YM8711kf0IFnD84KydbfFnV0LupfaJ57SHxX6EQpsO8YE5
as a valid skylink.There was a second shortcoming of the parser I've fixed which is that up until now it was incapable of detecting the raw link on its own line, which is also hard to believe but people are simply reporting it using obfuscated urls.
Example for Visual Changes
N/A
Checklist
Issues Closed
Closes SKY-1207