Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Update time format in email #29

Merged
merged 2 commits into from
Apr 21, 2022
Merged

[MINOR] Update time format in email #29

merged 2 commits into from
Apr 21, 2022

Conversation

peterjan
Copy link
Collaborator

PULL REQUEST

Overview

NCMEC reporting requires time.RFC3339, I mistakenly updated all formats in the codebase, the format in the emails however should be RFC1123 ideally

Example for Visual Changes

N/A

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

N/A

@peterjan peterjan requested review from ro-tex and kwypchlo April 21, 2022 08:47
@kwypchlo kwypchlo merged commit 4e77172 into main Apr 21, 2022
@kwypchlo kwypchlo deleted the pj/update-timestamps branch April 21, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants