Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a patch for an extra menu to choose the starter #96

Merged
merged 5 commits into from Mar 25, 2021
Merged

Adds a patch for an extra menu to choose the starter #96

merged 5 commits into from Mar 25, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 24, 2021

Adds a patch which lets the player discard the choice made by the personality quiz and choose the starter instead.
Seems to work on real hardware.
Extends overlay 13 size by 0x1000 bytes (should not be a problem since the size of this overlay still is below the size of some other menu overlays (e.g. 19)).

@theCapypara theCapypara self-assigned this Mar 24, 2021
@ghost
Copy link
Author

ghost commented Mar 24, 2021

Adds a patch to be patched over the previous one to skip the quiz part and directly go to the menu to choose the partner.
The behavior for the ribbon / items you get is not tested yet (should be either default or the one that corresponds to the selected pokémon's personality).

"MESSAGE/text_s.str": "---",
"MESSAGE/text_j.str": "---"}
MESSAGE = "Then, who would you like to be?"
# For xgettext scanning: _("Quel pokémon souhaitez-vous devenir?")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in next commit

@theCapypara theCapypara merged commit c08e2e4 into SkyTemple:master Mar 25, 2021
marius851000 pushed a commit to marius851000/skytemple-files that referenced this pull request Jul 9, 2022
Add support for editing banner fonts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants