Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patches to implement Fairy type and Fairy gummies. #92

Merged
merged 1 commit into from Mar 13, 2021
Merged

Add patches to implement Fairy type and Fairy gummies. #92

merged 1 commit into from Mar 13, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2021

Add patches to implement the Fairy type:

  • A patch to change the type match-up table implementation and add Fairy type as the "Neutral" (this replaces the old table with the 6th+ gens table) and all tables related to Gummi effects by type (IQ boosts/Belly recover).
  • A patch to transform unused item 138 into a Fairy-type Gummi.

To create those patches, some new files have been created:

  • Handler/Model/Writer for file "BALANCE/item_p.bin".
  • A patch to extract Spinda bar's item list.
  • Handler/Model/Writer for file "BALANCE/itembar.bin" (the file created by the patch mentioned in the previous point).

@@ -41,7 +41,7 @@ class MappaItemCategory(Enum):
THROWN_PIERCE = 0, 1, 6, [], [9]
THROWN_ROCK = 1, 7, 4, [9], []
BERRIES_SEEDS_VITAMINS = 2, 69, 40, [], [116, 117, 118]
FOODS_GUMMIES = 3, 109, 29, [116, 117, 118], []
FOODS_GUMMIES = 3, 109, 30, [116, 117, 118], []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this cause issues when the patch isn't applied?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not, since item # 138 isn't in any other category. It may cause slight issues when adding it to a floor before applying the patch, but the impact should be minimal. Could maybe add check to the UI, but idk if it's worth it.

@theCapypara theCapypara self-requested a review March 12, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants