Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sprite tile buffer setting and unknown second value to monster editing #17

Closed
theCapypara opened this issue Sep 18, 2020 · 1 comment

Comments

@theCapypara
Copy link
Member

theCapypara commented Sep 18, 2020

@Parakoopa I found out why Magikarp didn't evolve
There is another check I forgot about: There is a table inside arm9.bin, with an entry for each pokémon species (the primary gender is always used to access it, so there are 600 total entries). Each entry has 2 bytes: The "unknown evolution value" and some other thing that I don't know what it is. Most species have an unknown evolution value of 6, but I have also seen 9, 10, 11, 12, 14, 16, 17 and 18. Values <= 6 are turned into 6 by the ASM. If a pokémon and its evolution have a different value, the pokémon cannot evolve inside a dungeon.
Magikarp has 6, but Gyarados has 17, so that's why Magikarp can't evolve. I tested it again using Chinchou and Lanturn and it worked, since both have a value of 6.


Beep, boop, I'm a bot! This issue was created by @End in #reverse-engineering.

@theCapypara
Copy link
Member Author

It seems the value is not directly related to evolution, but to the sprite size.

@theCapypara theCapypara changed the title Add unknown evolution setting and unknown second value to monster editing Add sprite tile buffer setting and unknown second value to monster editing Sep 18, 2020
theCapypara added a commit to SkyTemple/skytemple that referenced this issue Sep 18, 2020
* When opening a Pokémon in SkyTemple the table that contains the sprite
  memory sizes will now be checked against the actual requirement of the
  sprite, if it doesn't match, a warning is shown and the value is
  corrected.
* When assigning new sprites to Pokémon the value mentioned above is
  updated.
marius851000 pushed a commit to marius851000/skytemple-files that referenced this issue Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant