Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude unit tests, examples and benchmarks from git archives #7

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Exclude unit tests, examples and benchmarks from git archives #7

merged 1 commit into from
Feb 13, 2018

Conversation

simonschaufi
Copy link
Contributor

No description provided.

roxblnfk
roxblnfk reviewed Jan 19, 2018
View reviewed changes
.gitattributes
@@ -0,0 +1,3 @@
/testunit export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore
Copy link
Contributor

@roxblnfk roxblnfk Jan 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\r\n at line 3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean add new line?

Copy link
Contributor

@roxblnfk roxblnfk Jan 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Add end of line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@simonschaufi simonschaufi force-pushed the exclude-tests-from-archive branch from 7979e82 to fada85a Compare January 19, 2018 14:14
@roxblnfk
Copy link
Contributor

what about /benches?

@simonschaufi
Copy link
Contributor Author

simonschaufi commented Jan 19, 2018 •
edited
Loading

I can add it as well. I think it makes sense. Just the examples could also be added in the download, or what do you think? I would exclude them as well as they are not productive code.

@roxblnfk
Copy link
Contributor

I would also exclude them

@simonschaufi simonschaufi force-pushed the exclude-tests-from-archive branch from fada85a to e39555f Compare January 19, 2018 14:51
@simonschaufi simonschaufi changed the title Exclude unit tests from git archives Exclude unit tests, examples and benchmarks from git archives Jan 19, 2018
@simonschaufi
Copy link
Contributor Author

are you able to merge this?

@roxblnfk
Copy link
Contributor

are you able to merge this?

No. I do not have write access

Skrol29
Skrol29 approved these changes Feb 13, 2018
View reviewed changes
Copy link
Owner

@Skrol29 Skrol29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Skrol29 Skrol29 merged commit 379c0c0 into Skrol29:master Feb 13, 2018
@simonschaufi simonschaufi deleted the exclude-tests-from-archive branch February 13, 2018 23:25
@mlocati mlocati mentioned this pull request Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

@Skrol29 Skrol29 Skrol29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonschaufi @roxblnfk @Skrol29