Aliases Update for Minecraft 1.17 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBentoBox
reviewed
Jun 10, 2021
TheBentoBox
approved these changes
Jun 10, 2021
|
Need to make some changes as aliases will not currently load on 1.17 correctly |
|
🎆 With this third pass, the aliases all successfully load on 1.17 (tested with debug mode on and stuff) 🥳 I think this PR is good to go now - but one final look from someone to make sure the name patterns for everything is good wouldn't hurt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add aliases for then new blocks and items added into Minecraft 1.17
I used the wiki along with a lovely document Shane gave me for reference (thanks!) to try and get everything.
However, it is possible I still missed some things so if anyone wants to double check I would appreciate it.
It is also possible I made some mistakes, as there were a lot of new blocks to cover.