PotionEffectType overhaul

[ShaneBeee]

Description

This PR aims to overhaul potion effect type in Skript.

It started with a bug:
"null" showing up in the docs for PotionEffectType:

It has since changed into re-working a lot:

• Cleanup PotionEffect utils to use keys instead of deprecated IDs (this fixes the "null" in docs bug)
• Add a potion effect type registry when it is available (1.20.x+)

---

Target Minecraft Versions: any
Requirements: none
Related Issues: none

[Moderocky]

Do you know if there is any way of removing the getId entirely? It's deprecated for removal (though that's hidden by the suppression).

[ShaneBeee]

Do you know if there is any way of removing the getId entirely? It's deprecated for removal (though that's hidden by the suppression).

could use keys/strings(from keys) instead.
looking at Spigot 1.19 docs, it has implemented Keyed for long enough.

I also considered doing an overhaul for this and using a RegistryClassInfo when the registry is available.

[ShaneBeee]

Do you know if there is any way of removing the getId entirely? It's deprecated for removal (though that's hidden by the suppression).

@Moderocky ok I re-wrote the whole PR.

• changed PotionEffectUtils to use keys instead of deprecated IDs
• Added a PotionEffectType registry (when available)

[Moderocky]

Looks good, thanks for fixing this.

[Moderocky]

@APickledWalrus will wait for you before merging because you have a stale potions rework PR.

[APickledWalrus]

A few minor things. One thing I wanted to ask about is the serialization changes. Is it possible that the serialization/deserialization process would change on the same version (that is, using the registry vs using PotionEffectType.getByName). Nice work!

[ShaneBeee]

Is it possible that the serialization/deserialization process would change on the same version (that is, using the registry vs using PotionEffectType.getByName). Nice work!

It shouldn't. The method just uses Keys internally anyways:
(from bukkit)