Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event-block to command struct #7320

Merged
merged 4 commits into from
Dec 29, 2024
Merged

Conversation

Efnilite
Copy link
Member

Description

Fixes #6852


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 28, 2024
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my approval

note:
I dont know if anyone told you, but you can't put "fixes #" in a PR messages, as it will close said issue when this PR is merged.
You need to put it into the "Related Issues" field.
It's not the end of the world, but for future ref!

@Moderocky
Copy link
Member

it will close said issue when this PR is merged

This only takes effect on the master branch so it shouldn't be a problem

Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming test failure isn't related to this.

@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 28, 2024
@Moderocky Moderocky merged commit 42ba3ea into SkriptLang:dev/feature Dec 29, 2024
5 checks passed
@Efnilite Efnilite deleted the fix-6852 branch January 1, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants