-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve registering event values #7269
Improve registering event values #7269
Conversation
related #5405 |
I might like to see Getter deprecated, and perhaps you could have it extend Function and just change the existing method signatures |
this PR was the beginning of my war against Getter. glad you agree :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
efy, told me to, I have no qualms about this, it's something I've been waiting for, makes event values not a pain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it need it like it very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you intend to finish updating BukkitEventValues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure this doesn't get merged before Sovde's comment gets a response.
It was mostly for example purposes. Idm though, should I or is it too prone to merge conflicts? |
Description
Example
Before
After
Target Minecraft Versions: any
Requirements: none
Related Issues: #5006