Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reload Event for SkriptConfig #7265

Merged

Conversation

APickledWalrus
Copy link
Member

Description

This PR adds event support to SkriptConfig using the new event registry API. I added one event for when the config is reloaded, though it would be trivial to add other events should the need arise. I also made some minor changes to the EventRegistry implementation for thread-safety.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@APickledWalrus APickledWalrus added the feature Pull request adding a new feature. label Dec 16, 2024
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 16, 2024
@sovdeeth sovdeeth merged commit 86488b8 into SkriptLang:dev/feature Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants