Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Paper API #7245

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Conversation

Burbulinis
Copy link
Contributor

Description

Update Paper API to 1.21.4


Target Minecraft Versions: 1.21.4
Requirements: none
Related Issues: none

@Fusezion
Copy link
Contributor

Fusezion commented Dec 7, 2024

Wanna do test environment while you're doing this

@NotSoDelayed
Copy link
Contributor

Should we really be updating it this soon? The only thing Skript will be missing is the new features where it might take a bit to be added into Skript, especially the next expected release is in less than a month from now.

@sovdeeth
Copy link
Member

sovdeeth commented Dec 8, 2024

Should we really be updating it this soon? The only thing Skript will be missing is the new features where it might take a bit to be added into Skript, especially the next expected release is in less than a month from now.

well the whole point of updating the dependency is so that new features are available to add

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 15, 2024
@sovdeeth sovdeeth added the 2.10 Targeting a 2.10.X version release label Dec 17, 2024
@ShaneBeee
Copy link
Contributor

ShaneBeee commented Dec 18, 2024

Correct me if Im wrong, but you updated Paper API, created a new test environment, but never implemented the environment anywhere??!?

EDIT: Wait, scratch that, the entire package will run.

That said, im assuming the 1.21.3 test can be removed and replaced with the new environment.
also def latestEnv = 'java21/paper-1.21.3.json' should be updated.

@sovdeeth
Copy link
Member

Correct me if Im wrong, but you updated Paper API, created a new test environment, but never implemented the environment anywhere??!?

The tests automatically run on any environments within their folder. Given minecraft's larger releases, it might be worth keeping minor update test environments around.
But the latestEnv should def be updated.

@ShaneBeee
Copy link
Contributor

The tests automatically run on any environments within their folder.

yeah I realized that shortly after I hit send, silly me.

Given minecraft's larger releases, it might be worth keeping minor update test environments around. But the latestEnv should def be updated.

Thats probably a good idea yeah.

@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 18, 2024
@Moderocky Moderocky merged commit b05f542 into SkriptLang:dev/feature Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.10 Targeting a 2.10.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants