Test - Update for MC 1.19+ #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
approved these changes
Dec 3, 2024
src/test/skript/tests/regressions/pull-5566-block iterator being 100 always.sk
Outdated
Show resolved
Hide resolved
|
I could be wrong, but I believe the test added from Equip's EffDetonate is the cause of those tests failing. As the explosion that's being detonated is at spawn where those 2 tests take place. |
APickledWalrus
approved these changes
Dec 15, 2024
src/test/skript/tests/syntaxes/expressions/ExprLowestHighestSolidBlock.sk
Outdated
Show resolved
Hide resolved
…lidBlock.sk Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to update tests by removing outdated version checks since Skript 2.10+ will be only for MC 1.19.4+
NOTES:
boats.skwas failing, so I temporarily commented out the line until that can be fixed (so tests can pass)Twas an Alias issue, Pickle informed me to update Aliases submodule on local and now it works.
4769-fire-visualeffect.skwas failing. I think the fire block was being set mid air and wouldn't set, so I just added a block below itpull-5566...skwas failing, it was getting the wrong blocks (probably edited in another test), so I shifted the test over 10 blocks along ZTarget Minecraft Versions: any
Requirements: none
Related Issues: none