Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sound for the third time (on dev/feature this time) #7205

Conversation

sovdeeth
Copy link
Member

@sovdeeth sovdeeth commented Nov 8, 2024

Description


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Nov 8, 2024
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sound-related tests seem to be failing

Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@ShaneBeee
Copy link
Contributor

ShaneBeee commented Nov 9, 2024

Also, tests are failing due to boats:
Screenshot 2024-11-08 at 4 23 30 PM

Might as well comment that line out or strip out the boats, and just re-add them back in in your boat PR
(just to get the test to pass)

@sovdeeth
Copy link
Member Author

sovdeeth commented Nov 9, 2024

Also, tests are failing due to boats: Screenshot 2024-11-08 at 4 23 30 PM

Might as well comment that line out or strip out the boats, and just re-add them back in in your boat PR (just to get the test to pass)

this is waiting on a skript aliases pr, which should be merged shortly

@ShaneBeee
Copy link
Contributor

ShaneBeee commented Nov 9, 2024

this is waiting on a skript aliases pr, which should be merged shortly

pardon my confusion, what does aliases have to do with EntityType (which is why the test is failing I believe)

@sovdeeth
Copy link
Member Author

sovdeeth commented Nov 9, 2024

this is waiting on a skript aliases pr, which should be merged shortly

pardon my confusion, what does aliases have to do with EntityType (which is why the test is failing I believe)

uh
boatdata failing -> pr to fix boat data failing, which has tests that revealed the any boat alias is missing the oak boat -> requires skript-aliases update
it could be merged without that part of the test, but it's an easy enough change I'm waiting for the aliases pr to merge

Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last one I promise

Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the test failing due to the Titanic sinking boats ... looks good to me.

Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just merge htis please

@APickledWalrus APickledWalrus merged commit 9553678 into SkriptLang:dev/feature Nov 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants