Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input API #7190

Merged
merged 22 commits into from
Nov 23, 2024
Merged

Input API #7190

merged 22 commits into from
Nov 23, 2024

Conversation

UnderscoreTud
Copy link
Member

Description

This PR covers all the features of the new Input API.

  • An expression to get what the player is currently pressing.
  • A condition to check if a player is pressing input keys.
  • An event called when a player sends an input update to the server.

Target Minecraft Versions: 1.21.3
Requirements: none
Related Issues: none

@UnderscoreTud UnderscoreTud added the feature Pull request adding a new feature. label Nov 3, 2024
Efnilite
Efnilite approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@Efnilite Efnilite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tests failing though :)

sovdeeth
sovdeeth requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice overall

@Pikachu920
Copy link
Member

i shed a tear when i saw the tests 🥹

@UnderscoreTud
Copy link
Member Author

i shed a tear when i saw the tests 🥹

i shed tears when i wrote the tests. for different reasons

APickledWalrus
APickledWalrus requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

@UnderscoreTud UnderscoreTud added the 2.10 Targeting a 2.10.X version release label Nov 9, 2024
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Nov 9, 2024
Absolutionism
Absolutionism suggested changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@Absolutionism Absolutionism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong on these, not sure.

APickledWalrus
APickledWalrus requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking excellent

UnderscoreTud and others added 4 commits November 19, 2024 20:50
APickledWalrus
APickledWalrus approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@Fusezion Fusezion mentioned this pull request Nov 21, 2024
Closed
1 task
@sovdeeth sovdeeth merged commit 6ba6706 into dev/feature Nov 23, 2024
6 checks passed
@APickledWalrus APickledWalrus deleted the feature/input-api branch January 6, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Efnilite Efnilite Efnilite approved these changes

@JakeGBLP JakeGBLP JakeGBLP left review comments

@Moderocky Moderocky Moderocky approved these changes

@Absolutionism Absolutionism Absolutionism approved these changes

Assignees
No one assigned
Labels
2.10 Targeting a 2.10.X version release feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@UnderscoreTud @Pikachu920 @sovdeeth @Moderocky @APickledWalrus @Efnilite @Absolutionism @JakeGBLP