fix various boat bugs #7185
Merged
fix various boat bugs #7185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bugs with comparisons, use simple entity data for 1.21.3+
Efnilite
approved these changes
Nov 3, 2024
ShaneBeee
reviewed
Nov 5, 2024
ShaneBeee
reviewed
Nov 5, 2024
ShaneBeee
reviewed
Nov 5, 2024
Moderocky
approved these changes
Nov 9, 2024
APickledWalrus
requested changes
Nov 9, 2024
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
APickledWalrus
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
switch to SimpleEntityDatas for 1.21.3+ boats (this solves so many issues)
adds pale oak boat support for winter drop
for <1.21.3, BoatData still has to exist. Not registered on higher versions.
Changed isOfItemtype logic to actually work!
Depends on SkriptLang/skript-aliases#120 for tests to pass.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6840