Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EffSecShoot #7136

Merged
merged 30 commits into from
Dec 24, 2024
Merged

EffSecShoot #7136

merged 30 commits into from
Dec 24, 2024

Conversation

TheAbsolutionism
Copy link
Contributor

Description

This PR aims to convert EffShoot into an EffSecShoot, allowing users to manipulate all or any entities/projectiles and shooters instantaneously

Target Minecraft Versions: any
Requirements: none
Related Issues: #4789

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 7, 2024
Efnilite
Efnilite requested changes Oct 7, 2024
View reviewed changes
src/main/java/ch/njol/skript/expressions/ExprShooter.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprShooter.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
sovdeeth
sovdeeth requested changes Oct 12, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
@TheAbsolutionism
Copy link
Contributor Author

Note:
For MC 1.19.4, to use launchProjectile with a consumer, requires the Bukkit Consumer type. Thus resulting the usage of Reflection in order to use the proper method.

@sovdeeth sovdeeth requested a review from Moderocky October 26, 2024 14:31
sovdeeth
sovdeeth requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
sovdeeth
sovdeeth approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EffSecShoot#walk() still isn't my favorite, but as discussed on discord it's good enough

Moderocky
Moderocky requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is nice but the implementation needs some work.

src/main/java/ch/njol/skript/expressions/ExprShooter.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
@Moderocky Moderocky requested a review from sovdeeth November 29, 2024 22:03
@sovdeeth sovdeeth added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. 2.10 Targeting a 2.10.X version release labels Dec 17, 2024
@Moderocky Moderocky merged commit 084bc7f into SkriptLang:dev/feature Dec 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Efnilite Efnilite Efnilite approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

Assignees
No one assigned
Labels
2.10 Targeting a 2.10.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheAbsolutionism @sovdeeth @Moderocky @Efnilite