Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async JUnit tests, on broadcast event and hover list test #7053

Merged
merged 23 commits into from
Oct 13, 2024
Merged

Add async JUnit tests, on broadcast event and hover list test #7053

merged 23 commits into from
Oct 13, 2024

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Sep 7, 2024 •
edited
Loading

Description

Addresses #6988 (comment) by adding async JUnit tests which run after the sync JUnit tests have finished. The async JUnit tests are run on a seperate thread but are still run sequentially on that thread to avoid clashes that may come up if they run at the same time.

  • This is used to add a test for ExprHoverList.
  • Also adds the on broadcast event for simple testing that these async JUnit tests work and the accompanying broadcasted message expression.

Target Minecraft Versions: any
Requirements: none
Related Issues: #6988

@Efnilite Efnilite marked this pull request as draft September 7, 2024 13:35
@Efnilite Efnilite marked this pull request as ready for review September 7, 2024 14:31
@TheLimeGlass TheLimeGlass added feature Pull request adding a new feature. unit testing For issues/PRs related to the Skript unit testing system. labels Sep 7, 2024
TheLimeGlass
TheLimeGlass approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@TheLimeGlass TheLimeGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing, but it looks good to me.

sovdeeth
sovdeeth requested changes Sep 8, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprMessage.java Outdated Show resolved Hide resolved
Efnilite and others added 4 commits September 8, 2024 22:19
@Efnilite @sovdeeth
Update src/main/java/ch/njol/skript/Skript.java
e894284 
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@Efnilite @sovdeeth
Update src/main/java/ch/njol/skript/Skript.java
544ca98 
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@Efnilite
update annot
35a5b22
@Efnilite
Merge remote-tracking branch 'origin/async-junit-tests' into async-ju…
cae331b 
…nit-tests
@Efnilite Efnilite requested a review from sovdeeth September 8, 2024 20:19
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 14, 2024
@Efnilite Efnilite mentioned this pull request Sep 20, 2024
Closed
@sovdeeth sovdeeth removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 20, 2024
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 26, 2024
@sovdeeth sovdeeth merged commit b36ca00 into SkriptLang:dev/feature Oct 13, 2024
5 checks passed
@Efnilite Efnilite deleted the async-junit-tests branch October 27, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. unit testing For issues/PRs related to the Skript unit testing system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Efnilite @sovdeeth @Moderocky @TheLimeGlass