Add cuboid syntax to ExprEntities #6900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
requested changes
Jul 14, 2024
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Efnilite
reviewed
Jul 14, 2024
sovdeeth
approved these changes
Jul 18, 2024
Moderocky
requested changes
Aug 17, 2024
TheLimeGlass
approved these changes
Aug 19, 2024
Moderocky
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to get entities from a cuboid. I feel like there might be a way to simplify the code but I can't think of it right now so I am opening this up to suggestions. I also don't really like what's going on in the toString but I will leave it for now
Target Minecraft Versions: any
Requirements: none
Related Issues: none