Variable Backup Files Purger #6851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
reviewed
Jul 3, 2024
Efnilite
reviewed
Jul 5, 2024
Changed to primitive java types Added checks within the method incase called manually by a user. Changed config option Add config description
Added info on what the user can not set the options to. Can be removed if needed.
Changed to a 1 liner option in config Changed method handler to support the new option Changed description in config
Added the option to all other applicable databases. Changed function to support other databases. Moved the main description of the option to the top database in the config. Re-worded the description.
sovdeeth
requested changes
Jul 12, 2024
1 task
Added, The ability to put 0 Added, 0 does not call "startBackupTask" Added, 0 deletes all files in backup directory Changed, Config for putting 0 Added, warning for putting 0 Changed, "backupPurge" method to allow 0 as a parameter Changed, filters files array only if tokeep > 0
sovdeeth
approved these changes
Aug 16, 2024
Moderocky
approved these changes
Aug 19, 2024
TheLimeGlass
suggested changes
Aug 30, 2024
So it doesnt look like its strictly only for .csv files
TheLimeGlass
approved these changes
Aug 30, 2024
Efnilite
approved these changes
Sep 6, 2024
…m/SkriptTest into dev/backup-purge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows Skript to purge backup files, if number of files is >=
requiredand will delete files starting from the oldest until number of files left =remainTarget Minecraft Versions: any
Requirements: none
Related Issues: none