Changeable Max Stack Size for Items and Inventory #6698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this PR also include changes to the |
The condition checks if the max stack size is more than 1, which to me it looks like it is fine as is, unless I’m missing something. |
Ye I have no idea what I was thinking when I looked at the condition earlier, looks so fine. Probably a result of no sleep tbh, my bad. |
sovdeeth
requested changes
May 29, 2024
sovdeeth
requested changes
May 31, 2024
…stack-size-api # Conflicts: # src/main/java/ch/njol/skript/expressions/ExprMaxStack.java
sovdeeth
approved these changes
Jul 18, 2024
APickledWalrus
approved these changes
Aug 16, 2024
Moderocky
requested changes
Aug 19, 2024
|
Java 17 ready! |
1 task
cheeezburga
requested changes
Sep 17, 2024
Moderocky
approved these changes
Sep 19, 2024
TheAbsolutionism
approved these changes
Nov 16, 2024
cheeezburga
approved these changes
Nov 16, 2024
Efnilite
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support of changeable max stack size of inventories and the recently introduced
max stack sizeItemMeta in Minecraft 1.20.5.Javadocs:
Note
Using GitHub actions to test the attached test scripts due to Skript testing environment abruptly failing. My sincerely apologies for any bulk commits from fixing tests.
Target Minecraft Versions: Minecraft 1.20.5 (changeable itemstack max stack size)
Requirements: Spigot 1.20.5 (changeable max stack size ItemMeta)
Related Issues: #5020 (inventory)