Deprecate Checker and replace with Java's Predicate. #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca1e8e5
into
SkriptLang:feature/deprecate-outdated-utils
5 checks passed
Moderocky
added a commit
that referenced
this pull request
May 30, 2024
* Make checker a Java predicate. * Deprecate unused Njol predicate for removal. * Make checker extensions use predicate directly. * Remove checker from expression. * Remove checker from utils. * Deprecate Checker for removal. * Abstract checker to predicate from simple syntax * Remove remaining uses of checker.
Moderocky
added a commit
that referenced
this pull request
Jan 1, 2025
* Make checker a Java predicate. * Deprecate unused Njol predicate for removal. * Make checker extensions use predicate directly. * Remove checker from expression. * Remove checker from utils. * Deprecate Checker for removal. * Abstract checker to predicate from simple syntax * Remove remaining uses of checker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces all uses of the pointless checker class with Java's predicate.
This is technically a breaking change: if something implements Expression directly (rather than one of its common subclasses, e.g. SimpleExpression, PropertyExpression) then it will have to change its Checker methods to Predicate methods.
To preserve compatibility everywhere else, the deprecated Checker now extends Predicate and forwards the method call itself, so addons can still feed old Checkers into the new Predicate arguments.
Target Minecraft Versions: any
Requirements: none
Related Issues: none