Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve /skript subcommand help colours #6654

Merged
merged 1 commit into from
May 31, 2024
Merged

Improve /skript subcommand help colours #6654

merged 1 commit into from
May 31, 2024

Conversation

bluelhf
Copy link
Contributor

@bluelhf bluelhf commented May 6, 2024

This PR switches the colour used for the arguments of /skript subcommands in help pages from dark red to dark cyan. Dark cyan is a less jarring colour and also matches the output from /skript info.

@bluelhf bluelhf changed the base branch from master to dev/patch May 6, 2024 11:17
@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.8 Targeting a 2.8.X version release labels May 6, 2024
@bluelhf
Copy link
Contributor Author

bluelhf commented May 6, 2024

Colour Image
Old Old colours
New New colours

@bluelhf
Copy link
Contributor Author

bluelhf commented May 6, 2024

@Moderocky re-run workflows pls?

@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label May 6, 2024
@ShaneBeee
Copy link
Contributor

ShaneBeee commented May 6, 2024 •
edited
Loading

Before this is merged, might I talk about the 2 different colours?
Maybe use LIGHT_CYAN instead to match the main command?
Screenshot 2024-05-06 at 11 23 52 AM

@APickledWalrus
Copy link
Member

Before this is merged, might I talk about the 2 different colours? Maybe use LIGHT_CYAN instead to match the main command? Screenshot 2024-05-06 at 11 23 52 AM

Agreed that we should choose one for consistency.

@bluelhf
Copy link
Contributor Author

bluelhf commented May 6, 2024

Before this is merged, might I talk about the 2 different colours?
Maybe use LIGHT_CYAN instead to match the main command?
Screenshot 2024-05-06 at 11 23 52 AM

They are at a different level in the command tree, which is why they originally had different colours

@Moderocky
Copy link
Member

Agreed that we should choose one for consistency.

The other subcommands already use a different colour from the top-level command. Cyan is consistent with them.

@Moderocky Moderocky force-pushed the enhancement/better-help-colours branch from 485ee75 to 855dc69 Compare May 31, 2024 11:01
@Moderocky Moderocky merged commit 4983d9c into SkriptLang:dev/patch May 31, 2024
5 checks passed
@bluelhf bluelhf deleted the enhancement/better-help-colours branch May 31, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnderscoreTud UnderscoreTud UnderscoreTud approved these changes

@AyhamAl-Ali AyhamAl-Ali AyhamAl-Ali approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
2.8 Targeting a 2.8.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bluelhf @ShaneBeee @APickledWalrus @Moderocky @sovdeeth @AyhamAl-Ali @UnderscoreTud