Fix exception when the location has no world in ExprBlocks. #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
Apr 19, 2024
APickledWalrus
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The other cases all check if the world exists and return null if not, but the direction case checks only the direction and not the world, so this fails later on in the iterator if there isn't a world.
I followed what the other cases do and return null if the world is null.
I also added an
isWorldLoadedfilter to the getter, which should be okay since it checks if the world is null and if Bukkit has actually initialised the world.Target Minecraft Versions: any
Requirements: none
Related Issues: closes #6480, closes #6479