-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Skript MinecraftServer.isRunning reflection on 1.20(.1) #6352
Fix Skript MinecraftServer.isRunning reflection on 1.20(.1) #6352
Conversation
Does it fix your issue when you test? |
I have made other changes to Ketting (adding the bukkit method back in). So even if I did compile this (which I didn't) it wouldn't test the relavent code paths. I don't even have this code locally, and haven't even looked, if this builds with maven or gradle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can replicate with Spigot servers, this does fix it.
What if the mappings was saved in a json file (or any other format) in the jar, so you don't have to change the code every major version? |
Then we'd just have to change the mappings every version, no? It seems like the same outcome to me. |
Yeah, fair enough. My idea was to just have a list of mappings, instead of adding another round of if statements. Kinda cleaner, but you still need to bump the list when needed, but I guess it's fine for now |
Ah I see what you mean. Sure, I think if we need to touch this again we should swap to a switch or a map like your suggestion, but I think we should aim to get rid of it by then if possible. |
Related #6351
Adds the obfuscated name for Server#isRunning for 1.20 versions.
Please note that whilst this change is untested, it should be correct.