Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server startup issue 1.19 #4849

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Fix server startup issue 1.19 #4849

merged 5 commits into from
Jun 29, 2022

Conversation

TheLimeGlass
Copy link
Contributor

Description

Adds mapping for 1.19 spigot server.

Target Minecraft Versions: 1.19 but reflection handles other versions.

@ShaneBeee ShaneBeee self-requested a review June 29, 2022 15:22
ShaneBeee
ShaneBeee approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Shane... and I approve this PR!

@TheLimeGlass
Copy link
Contributor Author

That is if actions works

@ShaneBeee ShaneBeee merged commit 97f1d3e into SkriptLang:master Jun 29, 2022
TPGamesNL pushed a commit to TPGamesNL/Skript that referenced this pull request Jun 29, 2022
@TheLimeGlass @TPGamesNL
Fix server startup issue 1.19 (SkriptLang#4849)
8945576 
(cherry picked from commit 97f1d3e)
TPGamesNL pushed a commit to TPGamesNL/Skript that referenced this pull request Jun 29, 2022
@TheLimeGlass @TPGamesNL
Fix server startup issue 1.19 (SkriptLang#4849)
73cee04 
(cherry picked from commit 97f1d3e)
@TheLimeGlass TheLimeGlass added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. labels Jun 30, 2022
TheLimeGlass pushed a commit that referenced this pull request Jun 30, 2022
@TPGamesNL
Parse more UnparsedLiterals, but only if they're actually meaningful (#…
c6bfd66 
…4776)

* Parse more UnparsedLiterals, but only if they're actually meaningful

* Fix visual effects not being visible further than 1 block away if optional range was not set.

* Fix server startup issue 1.19 (#4849)
@TheLimeGlass TheLimeGlass removed the completed The issue has been fully resolved and the change will be in the next Skript update. label Jun 30, 2022
AyhamAl-Ali pushed a commit to AyhamAl-Ali/Skript that referenced this pull request Jul 4, 2022
@TheLimeGlass @AyhamAl-Ali
Fix server startup issue 1.19 (SkriptLang#4849)
810f0da 
(cherry picked from commit 97f1d3e)
AyhamAl-Ali pushed a commit to AyhamAl-Ali/Skript that referenced this pull request Jul 4, 2022
@TPGamesNL @AyhamAl-Ali
Parse more UnparsedLiterals, but only if they're actually meaningful (S…
6ef76a1 
…kriptLang#4776)

* Parse more UnparsedLiterals, but only if they're actually meaningful

* Fix visual effects not being visible further than 1 block away if optional range was not set.

* Fix server startup issue 1.19 (SkriptLang#4849)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneBeee ShaneBeee ShaneBeee approved these changes

Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheLimeGlass @ShaneBeee