-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Minecraft 1.19 stuff #4834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new entities - new enchantment - update some classes due to changes in Paper 1.19
APickledWalrus
requested changes
Jun 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major ;D nice work
Although, do we need to add the new biomes anywhere? (E.g. lang file)
Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
src/main/java/ch/njol/skript/classes/data/DefaultComparators.java
Outdated
Show resolved
Hide resolved
APickledWalrus
approved these changes
Jun 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A second review could be good
skmedix
suggested changes
Jun 25, 2022
Co-authored-by: skmedix <skmedixs@gmail.com>
TheBentoBox
approved these changes
Jun 25, 2022
AyhamAl-Ali
pushed a commit
to AyhamAl-Ali/Skript
that referenced
this pull request
Jul 4, 2022
* Update Minecraft 1.19 stuff - new entities - new enchantment - update some classes due to changes in Paper 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add Minecraft 1.19 stuff to Skript
NOTE:
You may be asking yourself "Shane, why 'BoatChestData' and not 'ChestBoatData'?"
Well I did this strictly so BoatData and BoatChestData classes were grouped together
Target Minecraft Versions: 1.19
Requirements: none
Related Issues: