Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Minecraft 1.19 stuff #4834

Merged
merged 8 commits into from
Jun 28, 2022
Merged

Update Minecraft 1.19 stuff #4834

merged 8 commits into from
Jun 28, 2022

Conversation

ShaneBeee
Copy link
Contributor

@ShaneBeee ShaneBeee commented Jun 25, 2022

Description

This PR aims to add Minecraft 1.19 stuff to Skript

NOTE:
You may be asking yourself "Shane, why 'BoatChestData' and not 'ChestBoatData'?"
Well I did this strictly so BoatData and BoatChestData classes were grouped together


Target Minecraft Versions: 1.19
Requirements: none
Related Issues:

- new entities
- new enchantment
- update some classes due to changes in Paper 1.19
@ShaneBeee ShaneBeee added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jun 25, 2022
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major ;D nice work

Although, do we need to add the new biomes anywhere? (E.g. lang file)

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A second review could be good

Co-authored-by: skmedix <skmedixs@gmail.com>
@ShaneBeee ShaneBeee merged commit a850de2 into SkriptLang:master Jun 28, 2022
@ShaneBeee ShaneBeee deleted the feature/1-19-update branch June 28, 2022 22:42
@AyhamAl-Ali AyhamAl-Ali mentioned this pull request Jun 29, 2022
1 task
@TheLimeGlass TheLimeGlass added completed The issue has been fully resolved and the change will be in the next Skript update. and removed completed The issue has been fully resolved and the change will be in the next Skript update. labels Jun 30, 2022
AyhamAl-Ali pushed a commit to AyhamAl-Ali/Skript that referenced this pull request Jul 4, 2022
* Update Minecraft 1.19 stuff
- new entities
- new enchantment
- update some classes due to changes in Paper 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants