Fix Locale-related String conversion issues #4822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
approved these changes
Jun 19, 2022
1 task
AyhamAl-Ali
pushed a commit
to AyhamAl-Ali/Skript
that referenced
this pull request
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In many parts of Skript, when converting to lower/upper case, a Locale is not specified. This means that the default Locale is used (usually dependent on the user's system).
The following, taken from the
String#toLowerCase()javadoc, is an example of why this is an issue:Note: This method is locale sensitive, and may produce unexpected results if used for strings that are intended to be interpreted locale independently. Examples are programming language identifiers, protocol keys, and HTML tags. For instance, "TITLE".toLowerCase() in a Turkish locale returns "t\u0131tle", where '\u0131' is the LATIN SMALL LETTER DOTLESS I character.
The result within Skript is that unexpected characters sometimes pop up during the parsing process for users on different locales, causing parsing to unexpectedly fail without much explanation to the user.
Also see: #4821 (comment)
The fix is to simply specify
Locale.ENGLISHfor most occurences ofString#toLowerCaseandString#toUpperCase.Target Minecraft Versions: N/A
Requirements: N/A
Related Issues: