Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from check against Material.AIR to Material#isAir in drop effect. #4795

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

TFSMads
Copy link
Contributor

@TFSMads TFSMads commented Jun 9, 2022

Description

I have changed the air check to use Material#isAir instead of checking against Material.Air.


Target Minecraft Versions: any
Requirements: No additional requirements
Related Issues: #4757

@AyhamAl-Ali AyhamAl-Ali added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jun 9, 2022
Copy link
Member

@TPGamesNL TPGamesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on all of the PRs, it's very much appreciated :D

@TPGamesNL TPGamesNL merged commit c8e8d86 into SkriptLang:master Jun 9, 2022
@TFSMads
Copy link
Contributor Author

TFSMads commented Jun 9, 2022

After further testing i found a error, the fix uses the Material#isAir method which wasn't added before 1.15. So here is another fix :)
#4798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants