Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚒️ Replace color char in debug statements #4630

Merged
merged 6 commits into from
Apr 18, 2022
Merged

⚒️ Replace color char in debug statements #4630

merged 6 commits into from
Apr 18, 2022

Conversation

AyhamAl-Ali
Copy link
Member

Description

  • Replaces chat color codes in debugging statements instead of stripping them
  • Handle unhandled debugging statements for chat color codes

Before
image
image

After
image
image

Target Minecraft Versions: Any
Requirements: None
Related Issues: None

@AyhamAl-Ali AyhamAl-Ali added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Feb 25, 2022
AyhamAl-Ali and others added 2 commits March 9, 2022 00:07
@AyhamAl-Ali @TPGamesNL
Update src/main/java/ch/njol/skript/util/SkriptColor.java
39d2097 
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
@AyhamAl-Ali
Ready
b3a3fa7
@AyhamAl-Ali AyhamAl-Ali requested a review from TPGamesNL March 8, 2022 21:09
@AyhamAl-Ali AyhamAl-Ali mentioned this pull request Mar 27, 2022
Closed
@TPGamesNL TPGamesNL merged commit 521b7ee into SkriptLang:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moderocky Moderocky Moderocky approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@TPGamesNL TPGamesNL TPGamesNL approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AyhamAl-Ali @Moderocky @APickledWalrus @TPGamesNL