Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'no scripts found' warning displaying with a config line #4549

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

TPGamesNL
Copy link
Member

Description

Before PR:
image
This line in the config is unrelated, and it doesn't need to be displayed with the warning.
After PR:
image


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TPGamesNL TPGamesNL added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 29, 2022
@TheLimeGlass
Copy link
Contributor

TheLimeGlass commented Jan 29, 2022

Does it still say All scripts loaded without errors. before the no scripts found warning line? I think that line should be removed too or modified if no scripts were found as it's not loading anything aside from config if that's included.

@TPGamesNL
Copy link
Member Author

The config isn't included, but that'd be out of scope for this PR

@Pikachu920
Copy link
Member

instead of manually overriding the current node by creating a new LogEntry, could we update the config parser so that it resets the current node (SkriptLogger#getNode) to null when it finishes with the last node?

@TPGamesNL
Copy link
Member Author

instead of manually overriding the current node by creating a new LogEntry, could we update the config parser so that it resets the current node (SkriptLogger#getNode) to null when it finishes with the last node?

Good idea, done 👍

I could've made the change global for all SectionNode iteration, but that seems like a bad idea cause it looks to be deliberately made to set it to the SectionNode itself, so it'd probably break something:
image

@TPGamesNL TPGamesNL merged commit acf11ba into SkriptLang:master Feb 25, 2022
TPGamesNL added a commit to TPGamesNL/Skript that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants