-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option for player name regex #4396
Add config option for player name regex #4396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please change the min length from 1 to 3, since min. allowed nickname length is 3? It will make less unneeded Bukkit API calls if players make mistakes in commands
There are still player names with 2 characters. Although extremely rare they'll join your server, there are a few accounts. I believe Mojang confiscated the accounts that were inactive or compromised, but still allowed 2 letter account names that were active. There is a Youtube documentary on the user that still actively plays on Xa or Xe. |
There are people with 1 letter names too. The person named "G" joined my server a handful of years ago. They were still active as of 2019 too, at which point they swapped to a lowercase "g". It should be left as 1 character min. |
If we want to be reducing Mojang API lookups, we can loop |
In that case I'll change it back to a minimum of 1 character (I'm just gonna assume Mojang did not allow a 0 character name). |
Description
Adds a config option for the player name regex pattern.
Also includes changes from #4367, thanks @AyhamAl-Ali for that!
Target Minecraft Versions: any
Requirements: none
Related Issues: #4374, #4367